-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Update Instructions for rewrite_table_path. #12628
Conversation
@manuzhang Could you please help review this PR? Thank you very much! It's a small change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that there is no other => "..."
in the Spark docs.
@manuzhang I also noticed a small change. Since #11147 has been fixed and the latest version of Iceberg (apache-iceberg-1.8.1) has been released, which includes the fix for #11157, I believe we can remove the warning. Given that this change is minor, I don't think we need to submit a separate PR for the fix. |
@manuzhang Gentle ping! could you helping to merge this PR? Thank you very much! |
This looks fine to me, but actually would you mind putting the revert of warning for #11157 in separate pr for book-keeping purpose and ease of revert / cherry pick (if necessary) |
@szehon-ho Thank you for your message! I will split the pr and submit it according to your suggestion. |
Merged, thanks @slfan1989 for pr and extra work splitting it, and also @manuzhang @ebyhr for review! |
Doc: Update Instructions for rewrite_table_path.
We have recently been using rewrite_table_path and noticed an issue with the use of quotes in the examples provided in the documentation. While other procedures use single quotes for variables, this stored procedure uses double quotes.