Spark: Backport Spark 3.5 DVs related part to Spark 3.4 #12603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtongue
changed the title
|
@nastra Add some DVs related tests including V3 fields addition to SparkContent. Could you check the changes? If there's any additional files that I should add or some changes that should be removed, please let me know. |
nastra
approved these changes
Mar 21, 2025
|
@nastra Thank you! (and I should've shared this earlier for the PR, thanks!) |
lliangyu-lin
pushed a commit
to lliangyu-lin/iceberg
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the Spark 3.5 Deletion Vectors related part including tests into Spark 3.4, to reflect the changes in #12048 and #11485 to Spark 3.4 as well . The following classes in the
actionspackage are mainly included:RewritePositionDeleteFilesSparkActionandTestRewritePositionDeleteFilesAction.java(backporting Spark: Disable rewriting position deletes for V3 tables #12048)TestRewriteManifest(backporting Spark 3.5: Preserve data file reference during manifest rewrites #11457)