Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled #12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jbonofre @ajantha-bhat Please take a look for me, thanks. |
nastra
reviewed
Mar 13, 2025
| import java.sql.SQLException; | ||
| import java.util.Map; | ||
| import java.util.UUID; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.Path; |
There was a problem hiding this comment.
this shouldn't be a Hadoop Path
There was a problem hiding this comment.
Thanks @nastra, I replace it with java.io.File.
ebyhr
reviewed
Mar 14, 2025
| File currentMetadataLocation = new File(metadataFileLocation); | ||
|
|
||
| catalog.dropView(identifier); | ||
| assertThat(currentMetadataLocation.exists()).isTrue(); |
There was a problem hiding this comment.
AssertJ has a method to verify a file existence:
Suggested change
| assertThat(currentMetadataLocation.exists()).isTrue(); | |
| assertThat(currentMetadataLocation).exists(); |
| File currentMetadataLocation = new File(metadataFileLocation); | ||
|
|
||
| catalog.dropView(identifier); | ||
| assertThat(currentMetadataLocation.exists()).isFalse(); |
There was a problem hiding this comment.
Suggested change
| assertThat(currentMetadataLocation.exists()).isFalse(); | |
| assertThat(currentMetadataLocation).doesNotExist(); |
| @@ -138,4 +142,50 @@ public void testCommitExceptionWithMessage() { | |||
| .hasMessageStartingWith("View already exists: " + identifier); | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void dropViewShouldNotDropMetadataFileIfGcNotEnabled() throws IOException { | |||
There was a problem hiding this comment.
Why not add these tests to ViewCatalogTests? Also, throws IOException is redundant.
| ViewMetadata lastViewMetadata = null; | ||
| try { | ||
| lastViewMetadata = ops.current(); | ||
| } catch (NotFoundException e) { |
There was a problem hiding this comment.
When does ops.current() method throw NotFoundException? I think it throws NoSuchViewException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HiveCatalogimplementeddropViewin Hive: Add View support for HIVE catalog #9852 and the view metadata will be purged from storage ifTableProperties.GC_ENABLEDistrue(default)JdbcCatalogshould also purge view metadata in the same way.