-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Bump junit to 5.12.1, nessie to 0.103.2 #12391
base: main
Are you sure you want to change the base?
Conversation
build.gradle
Outdated
@@ -198,8 +198,10 @@ subprojects { | |||
dependencies { | |||
implementation libs.slf4j.api | |||
|
|||
testImplementation platform(libs.junit.bom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave introducing the BOM out for now. We can do that in a separate PR, where we'd also clean up how dependencies are defined for JUnit (e.g. similar to
Lines 460 to 471 in d6d97d1
compileOnly(platform(libs.awssdk.bom)) | |
compileOnly(libs.awssdk.s3accessgrants) | |
compileOnly("software.amazon.awssdk:url-connection-client") | |
compileOnly("software.amazon.awssdk:apache-client") | |
compileOnly("software.amazon.awssdk:auth") | |
compileOnly("software.amazon.awssdk:http-auth-aws-crt") | |
compileOnly("software.amazon.awssdk:s3") | |
compileOnly("software.amazon.awssdk:kms") | |
compileOnly("software.amazon.awssdk:glue") | |
compileOnly("software.amazon.awssdk:sts") | |
compileOnly("software.amazon.awssdk:dynamodb") | |
compileOnly("software.amazon.awssdk:lakeformation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd be happy to do the bom PR too (given this one still passes CI)
Looks like tests in the
@ajantha-bhat could you take a look please? |
@nastra: We probably need this PR to get merged first at Nessie side. Looks like Junit 5.12.0 has some breaking changes that need a new Nessie release so that we can fix "org.projectnessie.junit.engine.MultiEnvTestEngine could not be instantiated" error. |
Closes #12378
Closes #12381
Closes #12537
Closes #12538
As of Gradle 8, not explicitly depending upon
junit-platform-launcher
is deprecated (and will be required in Gradle 9)Also addsjunit-bom
as per their recommendation