Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call For Proposals Banner.html #11924

Closed
wants to merge 2 commits into from

Conversation

Nhyi-streamlit
Copy link
Contributor

Creating a banner for folks to see and engage on the "Call For Proposals" for Iceberg 2025 Summit

@github-actions github-actions bot added the docs label Jan 7, 2025
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea ! Thanks !

@RussellSpitzer
Copy link
Member

@Nhyi-streamlit could you paste a preview of what the site looks like with the banner in this pr?

@RussellSpitzer
Copy link
Member

    {% endblock %}
jinja2.exceptions.TemplateSyntaxError: Unexpected end of template. Jinja was looking for the following tags: 'endblock'. The innermost block that needs to be closed is 'block'.
make: *** [build] Error 1```

@@ -36,6 +36,15 @@
<div class="intro-message">
<h1>Apache Iceberg™</h1>
<h3>The open table format for analytic datasets.</h3>
{% extends "main.html" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a mistake In the copy paste

</a>
</div>

{% block tabs %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! Definitely a copy paste error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to make it a darker shade of blue. Also was the banner hyperlinked to CFP site? I can't really view it on my end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to view the site by cloning your repo,

and doing

cd site/
make serve

Which should download the whole internet, make a few git worktrees and at some point load up the site on your local machine at

INFO    -  [12:45:22] Serving on http://127.0.0.1:8000/

Then you can make real time changes and see how it looks. I think Ideally we copy btn element but I'm bad at HTML and CSS

                  <a class="btn btn-default btn-lg" href="$$$LINK TO CFP HERE$$$" target="_blank">
                  <span class="network-name">Iceberg Summit 2025 CFP is Open</span>
                  </a>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@RussellSpitzer
Copy link
Member

RussellSpitzer commented Jan 8, 2025

I removed the misplaced tags and did a preview,

image

I think the yellow is a little glaring? Do you have any idea's for a cleaner presentation? Maybe just match the style of the Social links below with a white background and curved corners?

@RussellSpitzer
Copy link
Member

Merged slightly updated version #11942 since @Nhyi-streamlit is on vacation 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants