Remove the dependencies.lock from git and make them re-generated when building project #1180
+2
−92,723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… building project.
Fokko
approved these changes
Jul 9, 2020
rdsr
approved these changes
Jul 9, 2020
rdblue
reviewed
Jul 9, 2020
build.gradle
Outdated
| @@ -103,6 +103,7 @@ subprojects { | |||
| compileJava { | |||
| options.encoding = "UTF-8" | |||
| } | |||
| compileJava.dependsOn(generateLock, saveLock) | |||
There was a problem hiding this comment.
We should remove the locking plugin as well, right?
|
I agree with doing this. Locking is really helpful when building a final app so you can ensure tests run with the same classpath that will be used in production. For a library like this, it makes far less sense. Huge lock files and confusing behavior when updating versions is not worth it. Before merging, I think we should remove the dependency lock plugin as well. |
|
+1 |
rdsr
approved these changes
Jul 10, 2020
rdblue
approved these changes
Jul 10, 2020
|
Looks like there isn't much more discussion. I'm going to merge this. Thanks @openinx and to everyone that took the time to review! |
aokolnychyi
pushed a commit
to aokolnychyi/iceberg
that referenced
this pull request
Aug 18, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will address the issue from #1176.