Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publish-docker.yml #11632

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Create publish-docker.yml #11632

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
12c31df
Create publish-docker.yml
sungwy Nov 22, 2024
0f7c89a
fix vars
sungwy Nov 22, 2024
548baac
add license
sungwy Nov 22, 2024
b4664a7
checkout java
sungwy Nov 22, 2024
dc1b668
Publish with version tag on tag push event
sungwy Nov 25, 2024
15507b1
rename docker image
sungwy Nov 28, 2024
134d3fe
use DOCKERHUB_NAME variable in tag
sungwy Nov 28, 2024
fd103c2
Merge branch 'apache:main' into publish-to-dockerhub
sungwy Nov 28, 2024
f590470
fix tagged publication
sungwy Nov 28, 2024
84632a0
fix
sungwy Nov 28, 2024
ff8eae5
fix2
sungwy Nov 28, 2024
d816e2d
move comment to related step
sungwy Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/workflows/publish-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#

name: Build and Push Docker Image

on:
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Login to Docker Hub
run: |
docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{ secrets.DOCKERHUB_TOKEN }}
- name: Build Iceberg Open API project
Fokko marked this conversation as resolved.
Show resolved Hide resolved
run: ./gradlew :iceberg-open-api:shadowJar
- name: Build Docker Image
run: docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-adapter-image/Dockerfile .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using apache/iceberg-rest-fixture ? If we have a consensus, I can rename apache/iceberg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the name iceberg-rest-fixture, it is a good name 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @jbonofre and @ajantha-bhat - I'm good with this new name suggestion as well

Copy link
Contributor Author

@sungwy sungwy Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jbonofre - the workflow run is resulting in an access denied response at the proposed namespace:

Run docker push $DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
The push refers to repository [docker.io/apache/iceberg-rest-fixture]
0[10](https://github.com/apache/iceberg/actions/runs/12121028652/job/33791062874#step:8:11)919b3091e: Preparing
32bf0953c155: Preparing
88ad36680f9c: Preparing
32e16cb4dcee: Preparing
2573e0d81582: Preparing
denied: requested access to the resource is denied

Would you have the permission to verify access of the docker hub username to the proposed namespace apache/iceberg-rest-fixture?

- name: Push Docker Image
run: docker push apache/iceberg-rest-adapter:latest
Loading