Data, Flink, Spark: Test deletes with format-version=3 #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Nov 13, 2024
| @@ -441,12 +441,6 @@ public void testPartitionSpecEvolutionRemovalV2() { | |||
| assertThat(tasks).hasSize(expectedScanTaskCount(3)); | |||
| } | |||
|
|
|||
| private DeleteFile posDelete(Table table, DataFile dataFile) { | |||
There was a problem hiding this comment.
this addresses #11485 (comment)
nastra
changed the title
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
Outdated
Show resolved
Hide resolved
mr/src/test/java/org/apache/iceberg/mr/TestInputFormatReaderDeletes.java
Show resolved
Hide resolved
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
reader-delete-tests
branch
from
86955f4 to
b8534f2
Compare
nastra
force-pushed
the
reader-delete-tests
branch
from
b8534f2 to
bbd0810
Compare
nastra
changed the title
nastra
force-pushed
the
reader-delete-tests
branch
from
bbd0810 to
bccbc14
Compare
amogh-jahagirdar
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of #11122