Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add loadMetricsContext method #11384

Closed
wants to merge 7 commits into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 24, 2024

Work in Progress / Draft

Looking for feedback:

  • is this a reasonable approach for loading a custom MetricsContext class?
  • is there a different approach that would be more idiomatic?

@sullis sullis force-pushed the sean/loadMetricsContext branch 4 times, most recently from 37fb758 to b88b3bd Compare October 28, 2024 02:50
@sullis sullis force-pushed the sean/loadMetricsContext branch from b88b3bd to e91e155 Compare October 28, 2024 15:03
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 28, 2024
@sullis
Copy link
Contributor Author

sullis commented Nov 28, 2024

Closing this PR. I do not have any plans to continue this.

@sullis sullis closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant