GCS: Refresh vended credentials #11282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
gcs-refresh-vended-credentials
branch
from
9838acb to
bc5a4e1
Compare
nastra
force-pushed
the
gcs-refresh-vended-credentials
branch
from
bc5a4e1 to
5c9e222
Compare
nastra
commented
Oct 24, 2024
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java
Outdated
Show resolved
Hide resolved
| Preconditions.checkState(!gcsCredentials.isEmpty(), "Invalid GCS Credentials: empty"); | ||
|
|
||
| Optional<Credential> credentialWithPrefix = | ||
| gcsCredentials.stream().max(Comparator.comparingInt(c -> c.prefix().length())); |
There was a problem hiding this comment.
Just want to call out that we have the same issue as with s3.
nastra
force-pushed
the
gcs-refresh-vended-credentials
branch
from
5c9e222 to
95042e7
Compare
nastra
force-pushed
the
gcs-refresh-vended-credentials
branch
from
95042e7 to
0af9234
Compare
danielcweeks
approved these changes
Oct 29, 2024
|
thanks for the review @danielcweeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.