Core: Propagate catalog-level properties to iceberg-views. #11025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
force-pushed
the
view_catalog_props
branch
from
e551058 to
a21f4db
Compare
nastra
reviewed
Sep 12, 2024
| @@ -79,6 +79,7 @@ protected BaseViewBuilder(TableIdentifier identifier) { | |||
| Preconditions.checkArgument( | |||
| isValidIdentifier(identifier), "Invalid view identifier: %s", identifier); | |||
| this.identifier = identifier; | |||
| this.properties.putAll(tableDefaultProperties()); | |||
There was a problem hiding this comment.
does it make sense to pass properties prefixed with table-default. to views? I think passing properties prefixed with view-default. seems more reasonable to me, which is being handled in #11064
There was a problem hiding this comment.
Thanks @nastra for reviewing it. I had this impression of applying catalog properties for both table and view. Else it will contain duplicate info for both table and view. Since #11064 is already in progress , Do you think I should continue this PR. It looks duplicate work for me. only diff is I am honoring table-override also with this PR.
WDYT? pl share the feedback.
nk1506
force-pushed
the
view_catalog_props
branch
from
a21f4db to
352bac1
Compare
|
Closing this, I will push this on the ongoing pr #11064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar like Iceberg-Table, allow view properties defaults to be configured at catalog level.