Ability to build for all Scala versions #10606
Conversation
snazy
force-pushed
the
all-scala-build
branch
5 times, most recently
from
53457b2 to
8d7edef
Compare
snazy
force-pushed
the
all-scala-build
branch
5 times, most recently
from
86e492b to
cbc746b
Compare
snazy
force-pushed
the
all-scala-build
branch
3 times, most recently
from
80a06d6 to
7153e47
Compare
| @@ -40,5 +40,4 @@ jobs: | |||
| java-version: 8 | |||
| - run: | | |||
| ./gradlew printVersion | |||
| ./gradlew -DallModules publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
| ./gradlew -DflinkVersions= -DsparkVersions=3.3,3.4,3.5 -DscalaVersion=2.13 -DhiveVersions= publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
| ./gradlew -DallModules=true -DallScalaVersions=true publishApachePublicationToMavenRepository -PmavenUser=${{ secrets.NEXUS_USER }} -PmavenPassword=${{ secrets.NEXUS_PW }} | |||
There was a problem hiding this comment.
-DallModules => -DallModules=true -- is this intentional change?
will -DallModules still have the effect it used to have?
There was a problem hiding this comment.
See https://github.com/apache/iceberg/pull/10606/files#diff-7f825392aa37acd1cee0c2e7b9bb7366ad6eac64f3e6cdd816e156bcb69d30deR92
It does not current old behavior
Forgive my ignorance. Does it affect the artifacts we build? Does it how we build them? Does it affect how we test them? |
There is no change in how things are built or tested. |
|
@RussellSpitzer you have time to review? |
Allows building for all Spark/Scala version combinations. Introduces new system properties to control the behavior: * `allScalaVersions=true` lets Spark build for all Scala versions * the previous property `scalaVersion` is now a version list via the `scalaVersions` property, provides backwards compatibility * the previous property `defaultScalaVersion` is now a version list via the `defaultScalaVersions` property, provides backwards compatibility The defaults, via `gradle.properties` do not change. Also... * Unify processing of the xyzVersions everywhere * Fix compilation bug in Flink 1.19 jmh code (was not built before) * Update release jobs/script * Remove "hack" for `:iceberg-bom` * Simplify and fix related usages of the build system properties
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Allows building for all Spark/Scala version combinations. Introduces new system properties to control the behavior:
allScalaVersions=truelets Spark build for all Scala versionsscalaVersionis now a version list via thescalaVersionsproperty, provides backwards compatibilitydefaultScalaVersionis now a version list via thedefaultScalaVersionsproperty, provides backwards compatibilityThe defaults, via
gradle.propertiesdo not change.Also...
:iceberg-bom