Spark: Backport #10373 to Spark 3.3 and 3.4 #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Curious, do we need similar of https://github.com/apache/iceberg/pull/10373/files#r1645018496 in spark 3.3 and 3.4
|
@dramaticlly Yes we should include the fix for RewriteManifests as well, good catch! |
amogh-jahagirdar
force-pushed
the
backport-spark-cleanup-fix
branch
from
7dfb606 to
9eeecac
Compare
dramaticlly
approved these changes
Jun 20, 2024
nastra
approved these changes
Jun 21, 2024
|
Thanks @dramaticlly @nastra for the review! |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10373 to Spark 3.3 and 3.4 to only perform eager cleanups in Spark writes when the failure is cleanable.