Migrate HadoopCatalog related tests in Flink #10358
Conversation
tomtongue
changed the title
|
Other |
tomtongue
force-pushed
the
mig-junit5-flink-hadoopcatalog
branch
from
8624b13 to
777c3a6
Compare
tomtongue
changed the title
|
@nastra Sorry for the delay. Could you review this PR when you have time? This PR includes a bit file changes. so if it's fine, I will add backports to other versions to this PR. |
| @@ -50,4 +51,17 @@ public static MiniClusterExtension createWithClassloaderCheckDisabled() { | |||
| .setConfiguration(DISABLE_CLASSLOADER_CHECK_CONFIG) | |||
| .build()); | |||
| } | |||
|
|
|||
| public static MiniClusterExtension createWithClassloaderCheckDisabled( | |||
There was a problem hiding this comment.
I don't think this is necessary (I don't see it being used anywhere)
There was a problem hiding this comment.
Thanks! Let me remove this in the next commit.
| @@ -122,4 +123,24 @@ public static CombinedScanTask createCombinedScanTask( | |||
|
|
|||
| return new BaseCombinedScanTask(fileTasks); | |||
| } | |||
|
|
|||
| public static CombinedScanTask createCombinedScanTask( | |||
There was a problem hiding this comment.
can you elaborate why this change is needed?
There was a problem hiding this comment.
The other createCombinedScanTask (described above in this class) is still used in other test classes which include JUnit4. This method still takes the TemporaryFolder argument. So, for this commit, I choose the method overloading. Once the other classes are migrated into JUnit5, I will remove the old createCombinedScanTask (which takes the TemporaryFolder argument). I will add a comment line for this.
|
Thanks for the review! and, sorry for much delay. The changes have conflics, so let me fix them and will commit again. |
tomtongue
force-pushed
the
mig-junit5-flink-hadoopcatalog
branch
from
5df014a to
e801ce5
Compare
|
@nastra Hi Eduard! When you have time, could you review the latest change again? |
There was a problem hiding this comment.
LGTM, thanks for working on this @tomtongue. Can you also please backport this to earlier Flink versions?
|
Thank you! Yes, I will submit the backport PR for this. |
Migrate the following classes in
iceberg-flinkto JUnit 5 for #9087FlinkTestBaseinherited classes (currently only including v1.19)TestFlinkIcebergSinkTestFlinkIcebergSinkBranchTestFlinkIcebergSinkV2TestFlinkIcebergSinkV2BranchTestSqlBaseTestFlinkSourceSqlTestIcebergSourceSqlHadoopTableResourcerelated test)TestColumnStatsWatermarkExtractorandReaderUtilAnd newly created file for
HadoopTableResourcealternative:HadoopTableExtension