DESC table should show table properties

apache · Jun 9, 2022 · 79dc60c · 79dc60c
1 parent 2244ade
commit 79dc60c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/spark/v3.2/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java b/spark/v3.2/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java
@@ -20,7 +20,9 @@
 package org.apache.iceberg.spark;
 
 import java.io.IOException;
+import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 import org.apache.iceberg.Table;
 import org.apache.iceberg.catalog.TableIdentifier;
 import org.apache.iceberg.spark.extensions.SparkExtensionsTestBase;
@@ -149,6 +151,18 @@ public void testCreateTable() {
     Assert.assertEquals("Should be partitioned on 3 columns", 3, third.spec().fields().size());
   }
 
+  @Test
+  public void testDescribeTable() {
+    // create table
+    sql("CREATE TABLE %s (id bigint, data string) USING iceberg", tableName);
+    sql("INSERT INTO %s VALUES (1, 'a'), (2, 'b'), (3, 'c')", tableName);
+    List<Object[]> tblPropRows = sql("DESC TABLE EXTENDED %s", tableName)
+            .stream().filter(tblPropRow -> tblPropRow[0].equals("Table Properties")).collect(Collectors.toList());
+
+    Assert.assertEquals(1, tblPropRows.size());
+    Assert.assertTrue(String.valueOf(tblPropRows.get(0)[1]).contains("metadata_location="));
+  }
+
   private Table getTable(String name) {
     return validationCatalog.loadTable(TableIdentifier.of("default", name));
   }

diff --git a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java b/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
@@ -168,6 +168,7 @@ public Map<String, String> properties() {
     if (icebergTable instanceof BaseTable) {
       TableOperations ops = ((BaseTable) icebergTable).operations();
       propsBuilder.put(FORMAT_VERSION, String.valueOf(ops.current().formatVersion()));
+      propsBuilder.put("metadata_location", String.valueOf(ops.current().metadataFileLocation()));
     }
 
     if (!icebergTable.sortOrder().isUnsorted()) {