Open
Conversation
rshkv
commented
Dec 24, 2024
crates/iceberg/src/metadata_scan.rs
Outdated
Comment on lines
217
to
232
| impl<'a> Iterator for Ancestors<'a> { | ||
| type Item = &'a SnapshotRef; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| if let Some(snapshot) = self.current_snapshot { | ||
| self.current_snapshot = match snapshot.parent_snapshot_id() { | ||
| Some(parent_snapshot_id) => self.table_metadata.snapshot_by_id(parent_snapshot_id), | ||
| None => None, | ||
| }; | ||
| Some(snapshot) | ||
| } else { | ||
| None | ||
| } | ||
| } | ||
| } |
rshkv
changed the title
rshkv
changed the title
Member
|
#822 has been merged, let's move on! |
rshkv
force-pushed
the
wr/metadata-history
branch
from
fc5c976 to
ddb6b14
Compare
Contributor
Author
|
Thank you for letting me know. Rebased on |
rshkv
force-pushed
the
wr/metadata-history
branch
from
ddb6b14 to
64f1448
Compare
rshkv
force-pushed
the
wr/metadata-history
branch
from
8c803d2 to
3875931
Compare
Member
|
Let's get #863 merge first. |
rshkv
force-pushed
the
wr/metadata-history
branch
from
3875931 to
93a31ed
Compare
rshkv
force-pushed
the
wr/metadata-history
branch
from
93a31ed to
6795fce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the History metadata table.
The history table is the snapshot log with ancestry information.
Reference implementations: