feat: Implement Decimal from/to bytes represents #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
sdd
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks @Xuanwo for fixing this, generally LGTM! Left some minor points to fix.
| PrimitiveLiteral::Int128(_) => todo!(), | ||
| PrimitiveLiteral::Int128(val) => { | ||
| let PrimitiveType::Decimal { precision, .. } = self.r#type else { | ||
| unreachable!( |
There was a problem hiding this comment.
Should we return error here?
There was a problem hiding this comment.
I think you're right @liurenjie1024 . I don't see a way that a malformed Datum could be created anywhere right now but this may not always be true as the project continues to evolve.
There was a problem hiding this comment.
So we will change Datum::to_bytes's return value into Result<ByteBuf>?
There was a problem hiding this comment.
So we will change Datum::to_bytes's return value into Result?
Looks good to me.
| // It's required by iceberg spec that we must keep the minimum | ||
| // number of bytes for the value | ||
| let required_bytes = Type::decimal_required_bytes(precision) | ||
| .expect("PrimitiveType must has valid precision") |
| @@ -3031,6 +3061,31 @@ mod tests { | |||
| check_avro_bytes_serde(bytes, Datum::string("iceberg"), &PrimitiveType::String); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn avro_bytes_decimal() { | |||
There was a problem hiding this comment.
Could we check add more tests for different precision?
chenzl25
added a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Oct 30, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #663
This PR will implement Decimal from/to bytes represents.