Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds client support for
POST /v1/{prefix}/transactions/commit, which commits changes to several tables atomically. Continues #2786 by @steveisTransaction::prepare_commit()builds a transaction'sTableCommitwithout refreshing or sending it;do_commitnow uses it too.RestCatalog::commit_transaction/RestSessionCatalog::commit_transactionsend the group in one request. The server returns no metadata, so callers reload the tables; on a conflict nothing is applied.cc @CTTY:
prepare_committakes&mut selfinstead of consuming the transaction, so it can still report the commit status for the cleanup planned in RFC-0003. Does that match what you have in mind?Are these changes tested?
prepare_commitand, with mockito, the request body,409, an unadvertised endpoint, and an empty group.409while the other table stays unchanged.AI Disclosure