Repository navigation
Conversation
4 of 40 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Expose the existing Parquet footer-prefetch and range-coalescing controls through
TableScanBuilderand forward them to the reader used byTableScan::to_arrow().Unset controls retain the reader defaults: a 512 KiB metadata hint and a 1 MiB coalescing gap. The gap controls when ranges can merge; it does not cap the resulting request size.
Are these changes tested?
Inline scan tests record storage byte ranges with row selection disabled, verify footer prefetch and the coalescing boundary, and check decoded rows. They also cover defaults, zero and maximum values, and empty scans.
Validation passed:
make check,make unit-test(workspace unit and doc tests), andgit diff --check. The public API snapshot was regenerated and adds only the two setters.The implementation assumes that the scan API should preserve the existing reader controls’ input types and zero/large-value semantics without additional validation limits. This PR does not establish optimal tuning values.
AI Disclosure
AI assisted with the implementation, API documentation, and tests.