You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(glue): Exclude historical schemas from Glue columns - #3390
This PR updates Glue schema conversion so AWS Glue StorageDescriptor.columns is populated only from the current Iceberg schema.
Previously, GlueSchemaBuilder::from_iceberg converted the current schema and then also converted historical schemas from table metadata. Those historical fields were written to Glue with iceberg.field.current=false, but Glue does not use that parameter to filter visible columns, which could cause duplicate columns to appear in the Glue Console after schema evolution.
Historical schemas are still preserved in Iceberg table metadata. This change only prevents them from being projected into Glue's visible column list.
Are these changes tested?
Yes.
Added a regression test covering schema evolution with historical schemas, and verified the Glue schema output contains only current schema fields.
This drops the older schemas entirely, so columns removed from the table also disappear from Glue. The Java catalog keeps them: toColumns in IcebergToGlueConverter writes the current schema first, then the older schemas with iceberg.field.current=false, and skips any name it has already added. The duplicates come from that missing name check, so keeping the loop and adding a HashSet of top-level names already written would fix #2749 and keep the Glue output the same as Java's. A table written by both Spark and iceberg-rust would otherwise see its Glue columns change depending on which engine committed last.
If the maintainers prefer current-schema-only, that's a fair choice too, but it's a behavior change from Java and probably worth saying so in the PR description.
Two smaller things:
The new test only adds a column, where both approaches give the same result. A case that drops a column (and one where a field keeps its name across schemas with a different type) would show which behavior is intended.
builder.is_current = false; and its comment can go: the fields are private and nothing reads them after from_iceberg returns.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR updates Glue schema conversion so AWS Glue
StorageDescriptor.columnsis populated only from the current Iceberg schema.Previously,
GlueSchemaBuilder::from_icebergconverted the current schema and then also converted historical schemas from table metadata. Those historical fields were written to Glue withiceberg.field.current=false, but Glue does not use that parameter to filter visible columns, which could cause duplicate columns to appear in the Glue Console after schema evolution.Historical schemas are still preserved in Iceberg table metadata. This change only prevents them from being projected into Glue's visible column list.
Are these changes tested?
Yes.
Added a regression test covering schema evolution with historical schemas, and verified the Glue schema output contains only current schema fields.
Ran locally:
cargo test -p iceberg-catalog-glue