Implement __getstate__ and __setstate__ on PyArrowFileIO and FsSpecFileIO so that they can be pickled#543
Merged
HonahX merged 1 commit intoapache:mainfrom Apr 7, 2024
Conversation
amogh-jahagirdar
force-pushed
the
serializable-file-io-impls
branch
4 times, most recently
from
76f9620 to
7ef4e5e
Compare
HonahX
reviewed
Apr 7, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this @amogh-jahagirdar . Just some small comments.
amogh-jahagirdar
force-pushed
the
serializable-file-io-impls
branch
from
7ef4e5e to
84eae82
Compare
amogh-jahagirdar
force-pushed
the
serializable-file-io-impls
branch
from
84eae82 to
1720211
Compare
Fokko
approved these changes
Apr 7, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks great @amogh-jahagirdar Thanks for fixing this!
HonahX
approved these changes
Apr 7, 2024
Contributor
|
Merged, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot pickle FileIO implementations currently due to the file system initialization being inside a LruCache wrapper instance.
For example if one tries to pickle.dumps(pyarowfileIO) now they will encounter the following error.
This change implements getstate and setstate on PyArrowFileIO and FsSpecFileIO so that they can be pickled
This is a pre-requisite to being able to serialize the Table instance.