Merged
Conversation
Fokko
force-pushed
the
fd-add-strict-metrics-evaluator
branch
from
c79e9cc to
b618e9c
Compare
This will enable use to delete whole datafiles by evaluating the metrics, and not needing to open the Parquet files.
Fokko
force-pushed
the
fd-add-strict-metrics-evaluator
branch
from
b618e9c to
c36e6dc
Compare
HonahX
approved these changes
Mar 15, 2024
pyiceberg/expressions/visitors.py
Outdated
Comment on lines
1473
to
1475
| field = self.struct.field(field_id=field_id) | ||
| if field is None: | ||
| raise ValueError(f"Cannot find field, might be nested or missing: {field_id}") |
Contributor
There was a problem hiding this comment.
Shall we extract this block to a method since it is used in many places? I think this can make it easy to update the error message later
Contributor
Author
There was a problem hiding this comment.
That's a good suggestion, I've extracted it out into a separate function 👍
Contributor
Author
|
Thanks @HonahX for the review 👍 |
This was referenced Mar 24, 2024
Closed
73 tasks
28 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable use to delete whole datafiles by evaluating the metrics, and not needing to open the Parquet files.