Conversation
mkdocs/docs/SUMMARY.md
Outdated
| - [Verify a release](verify-release.md) | ||
| - [How to release](how-to-release.md) | ||
| - [Code Reference](reference/) | ||
| - [Code Reference](reference/) <!-- markdown-link-check-disable-line --> |
There was a problem hiding this comment.
I tried to build the site locally but received the following error
mkdocs_literate_nav.parser.LiterateNavParseError: Expected no text after <a href="reference/">Code Reference</a>, but got ' <!-- markdown-link-check-disable-line -->'.
Seems we also need to use <!-- markdown-link-check-disable -->/<!-- markdown-link-check-enable--> here?
There was a problem hiding this comment.
good catch! I was able to verify that the updated PR can build the site successfully
cd mkdocs
mkdocs build --strict
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks @kevinjqliu
BTW, I noticed that the markdown-link-check isn't automatically run with this PR. Is it intended or we need to somehow update the workflow yml?
|
@HonahX that is weird. The github action is currently configured to run when there are changes to I see it ran for the latest commit in my github fork |
|
In fact, I'm not sure if the |
|
Looks like its related to this CI and integration test github actions both specifically reference the We also want this github action to run in pull requests I can open an issue for this |
|
I just pushed the change following the same format as https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml#L25 this PR should now run the |
|
Thanks for fixing the CI config! |
Backport to 0.6.1
* Github Action to check links in documentation (#324) * add github add to check md link * Only run under `mkdocs/**` * ws * make lint --------- Co-authored-by: Fokko Driesprong <fokko@apache.org> * Fix dead links in docs (#493) Backport to 0.6.1 --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> Co-authored-by: Fokko Driesprong <fokko@apache.org>
#324 added Github action to check link html links in docs. There are a few dead links in the most recent run.
https://github.com/kevinjqliu/iceberg-python/actions/runs/8124843259/job/22207404913
This PR corrects the dead links or disables checking for those particular cases.
Following instructions in
https://github.com/gaurav-nelson/github-action-markdown-link-check