Sort Order update#476
Merged
Fokko merged 11 commits intoapache:mainfrom Feb 29, 2024
anupam-saini:as-sort-order
Merged
Conversation
Fokko
reviewed
Feb 27, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for working on this, can you check the tests and CI? make install && make lint
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Contributor
Author
My bad, missed it this time. Fixed in the latest revision |
5 tasks
Fokko
reviewed
Feb 29, 2024
Fokko
reviewed
Feb 29, 2024
Fokko
approved these changes
Feb 29, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Two minor suggestions, but apart from that it looks good 👍
himadripal
pushed a commit
to himadripal/iceberg-python
that referenced
this pull request
Mar 1, 2024
* Implement sort order update * Cleanup * Add test * Add test * Update pyiceberg/table/metadata.py Co-authored-by: Fokko Driesprong <fokko@apache.org> * Lint * Nits * Nits --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to add and update the default sort order via
update_table_metadata