Allow setting {row-group,page} limit
#390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-fix-row-group-page-size
branch
from
edac3df to
4cd240f
Compare
Comment on lines
137
to
144
| PARQUET_ROW_GROUP_SIZE_BYTES = "write.parquet.row-group-size-bytes" | ||
| PARQUET_ROW_GROUP_SIZE_BYTES_DEFAULT = 128 * 1024 * 1024 # 128 MB | ||
|
|
||
| PARQUET_ROW_GROUP_LIMIT = "write.parquet.row-group-limit" | ||
| PARQUET_ROW_GROUP_LIMIT_DEFAULT = 128 * 1024 * 1024 # 128 MB | ||
|
|
||
| PARQUET_PAGE_SIZE_BYTES = "write.parquet.page-size-bytes" | ||
| PARQUET_PAGE_SIZE_BYTES_DEFAULT = 1024 * 1024 # 1 MB |
Contributor
There was a problem hiding this comment.
I think this should be fine for the initial PR just so people have the properties, but I do think we may want to benchmark these values more. I think in general, Arrow and DuckDB will benefit from smaller row group sizes because they are more aggressive on parallel reads. But of course we should measure that.
Fokko
force-pushed
the
fd-fix-row-group-page-size
branch
from
4cd240f to
0165e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of @HonahX's work in #388