Skip to content

add iceberg datafusion integration #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinjqliu
Copy link
Contributor

Rationale for this change

Add pyiceberg table integration so that pyiceberg Table can be pass in directly to datafusion's register_table_provider

Are these changes tested?

Yes

Are there any user-facing changes?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting stuff 🙌 should we also add a section to the docs?

@@ -1428,6 +1428,51 @@ def to_polars(self) -> pl.LazyFrame:

return pl.scan_iceberg(self)

def __datafusion_table_provider__(self) -> Any:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __datafusion_table_provider__(self) -> Any:
def __datafusion_table_provider__(self) -> IcebergDataFusionTable:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants