Turn ObjectStoreLocationProvider off by default

[kevinjqliu]

Closes #1721

Otherwise, there's a default behavior change in new 0.9.0 release. Previous versions will write to data/, new version will write to data/<hash>/

[Fokko]

Thanks for fixing this @kevinjqliu.

I think it would be good to add this to 0.9.0

[kevinjqliu]

reverts #1509, cc @smaheshwar-pltr

[smaheshwar-pltr]

Thanks for the ping @kevinjqliu.

(Feel free to respond later) Curious what the problem here was. I'd have thought that old tables would still be readable by new PyIceberg and old PyIceberg would still be able to read tables created by the new one. Is changing locations just too dramatic for this release?

@Fokko's #1452 (comment) that prompted this still seems reasonable (maybe longer-term), or is it not?

[kevinjqliu]

Is changing locations just too dramatic for this release?

My main concern was around the default behavior change. For example, if i had a pipeline running with 0.8.1 and now i upgrade to 0.9.0. The data file location is suddenly changed to use the hashed path. We can add it to the release notes, but i think changing the default behavior will surprise some users.

[smaheshwar-pltr]

Thanks @kevinjqliu for the explanation.
I said something similar in #1509 (comment) / #1509 (comment) so agreed!

[kevinjqliu]

:) Sorry for the back and forth!
Another thing is that having data/ as the default data location is more friendly to new users.