fix: Invert case_sensitive logic in StructType#1147
Merged
sungwy merged 4 commits intoapache:mainfrom Sep 9, 2024
Merged
Conversation
AnthonyLam
changed the title
case_sensitive logic in StructType
Collaborator
|
Hello @AnthonyLam, thank you for your contribution. Could you add a test to ensure the expected behavior? |
Contributor
Author
For sure! I've added a test in |
kevinjqliu
approved these changes
Sep 9, 2024
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
great catch! thanks for the contribution
Collaborator
|
Hi @AnthonyLam thank you for working on this PR and @ndrluis , @kevinjqliu thank you for the review! I've triggered the CI, and it looks like there's a few issues with the test. Once those are resolved, I'm happy to do another round of review |
sungwy
approved these changes
Sep 9, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* fix: Invert logic in StructType * Add test for StructType.field_by_name * Remove var I forgot about. * Fix formatting post-lint
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* fix: Invert logic in StructType * Add test for StructType.field_by_name * Remove var I forgot about. * Fix formatting post-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
field_by_namemethod inStructTypeseems to have inverted logic on thecase_sensitiveparameter.