Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Break down very large table/__init__.py module #1144

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Refactoring: Break down very large table/__init__.py module #1144

merged 3 commits into from
Sep 8, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Sep 7, 2024 •
edited
Loading

The table/__init__.py module has grown to be extremely large at ~4500 lines, and often leads to issues in searching code on Github. This PR refactors the table/__init__.py module into smaller modules:

table
└__init__.py (Table, Transaction)
└ inspect.py (InspectTable)
└ update
    └__init__.py (TableMetadataUpdate, TableUpdate, TableRequirement)
    └ schema.py (UpdateSchema, _ApplyChanges, PartnerIdByNameAccessor, UnionByNameVisitor)
    └ snapshot.py (UpdateSnapshot, ManageSnapshots, _SnapshotProducer, DeleteFiles, AppendFiles, OverwriteFiles, _ManifestMergeManager,)
    └ spec.py (UpdateSpec)

@sungwy sungwy changed the title Refactoring: Break down very table module Refactoring: Break down very large table/__init__.py module Sep 7, 2024
@sungwy sungwy requested review from Fokko and kevinjqliu September 7, 2024 15:41
kevinjqliu
kevinjqliu approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks for working on this!

@sungwy sungwy merged commit d587e67 into apache:main Sep 8, 2024
8 checks passed
@sungwy sungwy deleted the split-table-monolith branch September 8, 2024 14:53
@sungwy sungwy restored the split-table-monolith branch September 8, 2024 17:09
@sungwy sungwy mentioned this pull request Sep 9, 2024
Merged
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@sungwy
Refactoring: Break down very large table/__init__.py module (apache…
1917dd3 
…#1144)

* split up table module

* refactoring

* license
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@sungwy
Refactoring: Break down very large table/__init__.py module (apache…
af66f5d 
…#1144)

* split up table module

* refactoring

* license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinjqliu kevinjqliu kevinjqliu approved these changes

@Fokko Fokko Awaiting requested review from Fokko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungwy @kevinjqliu