Repository navigation
fix: locate release SDK verifier outside CI - #524
Merged
Merged
Conversation
This was referenced Oct 13, 2026
Pengzna
previously approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
MrJs133
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organization counterpart: hugegraph#49.
Toolchain's source release packaging is moving its existing SDK verifier from .github/scripts/ to hugegraph-client/assembly/travis/ so .github can be excluded from source archives. The validator currently hardcodes the old location.
Prefer hugegraph-client/assembly/travis/verify_candidate_image_sdk.py and fall back to the legacy location for already-uploaded candidates. Keep the existing missing-verifier failure and all SDK checks. This is a two-line path compatibility change with no new script or dependency.
Validation: shell syntax, shellcheck, git diff --check and all 34 existing validator tests passed. No SVN artifacts were downloaded, extracted or executed locally. Full candidate runtime checks have not been repeated for this path-only change.
Paired packaging change: apache/hugegraph-toolchain#813. Merge this compatibility change before building candidates from that Toolchain change; older candidates remain supported.
Conceptual overview
Conceptual overview: prefer hugegraph-client/assembly/travis/verify_candidate_image_sdk.py, fall back to the previous .github/scripts path. Land this compatibility change before using the new Toolchain source layout. Not test evidence.