Repository navigation
Conversation
- replace the obsolete raw argument-count rule - document minimal mapping and response-file calls - clarify relative paths and credential file permissions - explain writable progress directories in both languages
This was referenced Oct 12, 2026
bitflicker64
left a comment
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: no. Summary: The argument-file section matches the merged loader change (apache/hugegraph-toolchain#808) and the English and Chinese pages agree; the only issue is that the reworded progress-file note overstates when a progress file is written on master. Evidence: static read of LoadOptions.parseOptions, LoadContext.close, LoadProgress, LoadUtil.getStructDirPrefix, LoadOptionsTest and bin/hugegraph-loader.sh at toolchain master 2692b6bf, JCommander 1.78 readFile bytecode (one argument per non-empty, non-# line), and the full diff of both pages at 65e9719.
- limit progress writes to normal completion - explain the unexpected failure boundary - align both language versions with loader behavior
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Loader guide rejected commands with fewer than three arguments, contradicting the corrected mapping-only and native JCommander argument-file behavior. The English and Chinese guides now show equivalent
--file struct.jsonand@loader.argscalls, relative-path handling, credential-file permissions and writable progress directories.Paired code fix: ASF toolchain #808, from the same source branch validated in org #61. Coordinate the code and website merges.
Validation: complete source link checks, strict Hugo production build, fresh bilingual HTML checks and independent document review passed. CI helpers and locked theme files are unchanged from the published cold-cache fix. The same documentation branch passed the selected org site build and browser validation before submission here.