Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Mark advanced configs and fix since version #9757

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[MINOR] Mark advanced configs and fix since version #9757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lient/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class HoodieCompactionConfig extends HoodieConfig {
.key("hoodie.log.compaction.enable")
.defaultValue("false")
.markAdvanced()
.sinceVersion("0.14")
.sinceVersion("0.14.0")
.withDocumentation("By enabling log compaction through this config, log compaction will also get enabled for the metadata table.");

public static final ConfigProperty<String> INLINE_LOG_COMPACT = ConfigProperty
Expand Down
3 changes: 2 additions & 1 deletion hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Integer> NUM_RETRIES_ON_CONFLICT_FAILURES = ConfigProperty
.key("hoodie.write.num.retries.on.conflict.failures")
.defaultValue(0)
.sinceVersion("0.13.0")
.markAdvanced()
.sinceVersion("0.14.0")
.withDocumentation("Maximum number of times to retry a batch on conflict failure.");

public static final ConfigProperty<String> WRITE_SCHEMA_OVERRIDE = ConfigProperty
Expand Down
5 changes: 4 additions & 1 deletion hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.hudi.exception.HoodieNotSupportedException;

import javax.annotation.concurrent.Immutable;

import java.io.File;
import java.io.FileReader;
import java.io.IOException;
Expand Down Expand Up @@ -91,7 +92,7 @@ public final class HoodieMetadataConfig extends HoodieConfig {
.key(METADATA_PREFIX + ".log.compaction.enable")
.defaultValue("false")
.markAdvanced()
.sinceVersion("0.14")
.sinceVersion("0.14.0")
.withDocumentation("This configs enables logcompaction for the metadata table.");

// Log blocks threshold, after a file slice crosses this threshold log compact operation is scheduled.
Expand Down Expand Up @@ -280,6 +281,7 @@ public final class HoodieMetadataConfig extends HoodieConfig {
public static final ConfigProperty<Integer> RECORD_INDEX_MAX_PARALLELISM = ConfigProperty
.key(METADATA_PREFIX + ".max.init.parallelism")
.defaultValue(100000)
.markAdvanced()
.sinceVersion("0.14.0")
.withDocumentation("Maximum parallelism to use when initializing Record Index.");

Expand Down Expand Up @@ -308,6 +310,7 @@ public final class HoodieMetadataConfig extends HoodieConfig {
public static final ConfigProperty<Long> MAX_LOG_FILE_SIZE_BYTES_PROP = ConfigProperty
.key(METADATA_PREFIX + ".max.logfile.size")
.defaultValue(2 * 1024 * 1024 * 1024L) // 2GB
.markAdvanced()
.sinceVersion("0.14.0")
.withDocumentation("Maximum size in bytes of a single log file. Larger log files can contain larger log blocks "
+ "thereby reducing the number of blocks to search for keys");
Expand Down
Loading