Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Move hoodie hfile/orc reader/writer test cases from hudi-client-common to hudi-common #9103

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Jun 30, 2023

Change Logs

Move hoodie hfile/orc reader/writer test cases from hudi-client-common to hudi-common.

Impact

None

Risk level (write none, low medium or high below)

Low

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@Mulavar
Copy link
Member Author

Mulavar commented Jun 30, 2023

Since hfile/orc reader/writer are written in the hudi-common module, it is better to write the test cases in the same module.

@Mulavar Mulavar force-pushed the MINOR-9102 branch 2 times, most recently from 6c97beb to f26d06b Compare June 30, 2023 04:51
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll rebase this PR on the latest master and land it.

@yihua yihua changed the title [MINOR]move hoodie hfile/orc reader/writer test cases from hudi-client-common to hudi-common [MINOR] Move hoodie hfile/orc reader/writer test cases from hudi-client-common to hudi-common Sep 17, 2023
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit be0c307 into apache:master Sep 17, 2023
26 of 29 checks passed
yihua added a commit that referenced this pull request Feb 27, 2024
…nt-common to hudi-common (#9103)

Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants