Repository navigation
Introduce HoodieReadHandle abstraction into index - #726
Merged
Merged
Conversation
vinothchandar
commented
Jun 11, 2019
vinothchandar
commented
Member
- Generalized BloomIndex to work with file ids instead of paths
- Abstracted away Bloom filter checking into HoodieLookupHandle
- Abstracted away range information retrieval into HoodieRangeInfoHandle
- Generalized BloomIndex to work with file ids instead of paths - Abstracted away Bloom filter checking into HoodieLookupHandle - Abstracted away range information retrieval into HoodieRangeInfoHandle
bvaradar
approved these changes
Jun 12, 2019
bvaradar
left a comment
bvaradar
left a comment
Contributor
There was a problem hiding this comment.
Handles look very clean now.
| * - Whether it belongs to the same partitionPath as existing records - Whether the current file written bytes lt max | ||
| * file size | ||
| */ | ||
| public boolean canWrite(HoodieRecord record) { |
Contributor
There was a problem hiding this comment.
Move this to WriteHandle ?
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Jun 5, 2024
This was referenced Oct 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.