refactor: Add Lombok annotations to hudi-spark,hudi-spark-common #17718
+189
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voonhous
force-pushed
the
lombokify-hudi-spark
branch
from
e60079a to
33ce24e
Compare
voonhous
force-pushed
the
lombokify-hudi-spark
branch
from
33ce24e to
d1d8220
Compare
voonhous
changed the title
voonhous
force-pushed
the
lombokify-hudi-spark
branch
from
33b949e to
34a619b
Compare
CTTY
approved these changes
Dec 26, 2025
Contributor
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
LGTM! There are some places where we can apply parameterized logging, would be good if we can address them
| * Note: Explicit setters are used instead of Lombok's @Setter annotation because this class is accessed from Scala code | ||
| * (RunBootstrapProcedure.scala). Since Scala compilation happens before Java compilation in the Maven build lifecycle, | ||
| * Lombok-generated methods would not be visible to the Scala compiler, causing compilation errors. | ||
| */ |
| this.props = this.propsFilePath == null || this.propsFilePath.isEmpty() ? buildProperties(this.configs) | ||
| : readConfig(fs.getConf(), new StoragePath(this.propsFilePath), this.configs).getProps(true); | ||
| LOG.info("Starting data import with configs : " + props.toString()); | ||
| log.info("Starting data import with configs : " + props.toString()); |
Contributor
There was a problem hiding this comment.
We can apply parameterized logging
| } | ||
| this.bootstrapConfig = builder.build(); | ||
| LOG.info("Created bootstrap executor with configs : " + bootstrapConfig.getProps()); | ||
| log.info("Created bootstrap executor with configs : " + bootstrapConfig.getProps()); |
Contributor
There was a problem hiding this comment.
We can apply parameterized logging
| writer.save(tablePath); // ultimately where the dataset will be placed | ||
| String commitInstantTime1 = HoodieDataSourceHelpers.latestCommit(fs, tablePath); | ||
| LOG.info("First commit at instant time :" + commitInstantTime1); | ||
| log.info("First commit at instant time :" + commitInstantTime1); |
Contributor
There was a problem hiding this comment.
We can apply parameterized logging to some places in this class
| private DataFrameWriter<Row> updateHiveSyncConfig(DataFrameWriter<Row> writer) { | ||
| if (enableHiveSync) { | ||
| LOG.info("Enabling Hive sync to " + hiveJdbcUrl); | ||
| log.info("Enabling Hive sync to " + hiveJdbcUrl); |
| FileSystem fs = FileSystem.get(jssc.hadoopConfiguration()); | ||
| String commitInstantTime1 = HoodieDataSourceHelpers.latestCommit(fs, tablePath); | ||
| LOG.info("Commit at instant time :" + commitInstantTime1); | ||
| log.info("Commit at instant time :" + commitInstantTime1); |
| waitTillNCommits(fs, numExpCommits, 180, 3); | ||
| commitInstantTime2 = HoodieDataSourceHelpers.listCommitsSince(fs, tablePath, commitInstantTime1).stream().sorted().findFirst().get(); | ||
| LOG.info("Second commit at instant time :" + commitInstantTime2); | ||
| log.info("Second commit at instant time :" + commitInstantTime2); |
Contributor
There was a problem hiding this comment.
We can apply parameterized logging to some places in this class
| // Ensure all commits were synced to the Metadata Table | ||
| HoodieTableMetaClient metadataMetaClient = createMetaClient(metadataTableBasePath); | ||
| LOG.warn("total commits in metadata table " + metadataMetaClient.getActiveTimeline().getCommitsTimeline().countInstants()); | ||
| log.warn("total commits in metadata table " + metadataMetaClient.getActiveTimeline().getCommitsTimeline().countInstants()); |
Contributor
There was a problem hiding this comment.
We can apply parameterized logging to some places in this class
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR refactors the
hudi-spark-datasource/hudi-sparkandhudi-spark-datasource/hudi-spark-commonmodules to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicitLoggerinstantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j,@Getter,@Setter,@NoArgsConstructor,@AllArgsConstructor,@Data,@Value,@ToString).This improves code readability and maintainability without altering the runtime logic.
Summary and Changelog
This change introduces the Lombok dependency to the
hudi-spark-datasource/hudi-sparkandhudi-spark-datasource/hudi-spark-commonmodules and refactors several classes to utilize Lombok annotations.hudi-spark-datasource/hudi-sparkandhudi-spark-datasource/hudi-spark-commonmodules.Impact
Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
Documentation Update
none
Contributor's checklist