[HUDI-7418] Add file extension filter for s3 incr source #10694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
approved these changes
Feb 19, 2024
yihua
reviewed
Feb 19, 2024
| filePathSizeAndCommitTime.add(Triple.of("path/to/file2.json", 150L, "1")); | ||
| filePathSizeAndCommitTime.add(Triple.of("path/to/file4.json", 50L, "2")); | ||
| filePathSizeAndCommitTime.add(Triple.of("path/to/file5.json", 150L, "2")); | ||
| filePathSizeAndCommitTime.add(Triple.of(String.format("path/to/file1%s", extension), 100L, "1")); |
There was a problem hiding this comment.
Add a file that does not end with the extension to test the filter?
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Feb 20, 2024
We have support for filtering the input files based on an extension (custom) for GCS Incr Source that can be configured. But we don't have the same for the S3 incr source (which always assumes that file extension is same as the format which may not be the case always). Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
nsivabalan
reviewed
Feb 20, 2024
| // add file format filtering by default | ||
| filter = filter + " and " + S3_OBJECT_KEY + " like '%" + fileFormat + "%'"; | ||
| // Match files with a given extension, or use the fileFormat as the fallback incase the config is not set. | ||
| if (!StringUtils.isNullOrEmpty(getStringWithAltKeys(props, CLOUD_DATAFILE_EXTENSION, true))) { |
There was a problem hiding this comment.
can we consider moving this to common class and use it across both s3 and gcs ?
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
We have support for filtering the input files based on an extension (custom) for GCS Incr Source that can be configured. But we don't have the same for the S3 incr source (which always assumes that file extension is same as the format which may not be the case always). Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
We have support for filter the input files based on an extension (custom) for GCS Incr Source that can be configured. But we don't have the same for the S3 incr source (which always assumes that file extension is same as the format which may not be the case always).
Impact
Low impact
Risk level (write none, low medium or high below)
Low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist