[HUDI-7357] Introduce generic StorageConfiguration #10586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinothchandar
approved these changes
Feb 6, 2024
hudi-io/src/test/java/org/apache/hudi/io/storage/TestStorageConfigurationBase.java
Outdated
Show resolved
Hide resolved
...doop-common/src/test/java/org/apache/hudi/storage/hadoop/TestHadoopStorageConfiguration.java
Outdated
Show resolved
Hide resolved
yihua
force-pushed
the
HUDI-7357-introduce-generic-conf
branch
from
e6a99b7
to
ce36bbb
Compare
|
CI is green. |
yihua
added a commit
that referenced
this pull request
Feb 27, 2024
This commit introduces the generic `StorageConfiguration` to store configuration for I/O with `HoodieStorage`. Given there's overhead of reinitializing Hadoop's `Configuration` instance, the approach is to wrap the instance in the `HadoopStorageConfiguration` implementation. This change will enable us to remove our dependency on Hadoop's `Configuration` class. When integrated, places using `Configuration` will be replaced by `StorageConfiguration` and the `StorageConfiguration` will be passed around for instantiating `HoodieStorage` (unless Hadoop-based readers need the `Configuration` instance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR introduces the generic
StorageConfigurationto store configuration for I/O withHoodieStorage. Given there's overhead of reinitializing Hadoop'sConfigurationinstance, the approach is to wrap the instance in theHadoopStorageConfigurationimplementation. This change will enable us to remove our dependency on Hadoop'sConfigurationclass. When integrated, places usingConfigurationwill be replaced byStorageConfigurationand theStorageConfigurationwill be passed around for instantiatingHoodieStorage(unless Hadoop-based readers need theConfigurationinstance).This is part of the effort to provide Hudi storage abstraction and decouple
hudi-commonfrom hadoop dependencies. For reference, the single big-change PR can be found here: #10360.Impact
No impact give this PR does not have the integration.
Risk level
none
Documentation Update
N/A
Contributor's checklist