Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] DataStream need in closeure in FileSystemBasedLockProvider #10411

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[MINOR] DataStream need in closeure in FileSystemBasedLockProvider #10411

merged 1 commit into from
Dec 27, 2023

Conversation

xuzifu666
Copy link
Member

Change Logs

DataStream need in closeure in FileSystemBasedLockProvider

Impact

low

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@xuzifu666
Copy link
Member Author

@bvaradar PTAL

yanghua
yanghua approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bvaradar
bvaradar approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 10bc664 into apache:master Dec 27, 2023
24 of 31 checks passed
yihua pushed a commit that referenced this pull request Feb 27, 2024
@xuzifu666 @yihua
[MINOR] DataStream need in closeure in FileSystemBasedLockProvider (#…
5faefcd 
…10411)

Co-authored-by: xuyu <11161569@vivo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiarixiaoyao xiarixiaoyao xiarixiaoyao approved these changes

@bvaradar bvaradar bvaradar approved these changes

@yanghua yanghua yanghua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xuzifu666 @hudi-bot @yanghua @bvaradar @xiarixiaoyao @yihua