Skip to content

Commit

Permalink
Addressing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nsivabalan committed Nov 20, 2023
1 parent 9a9e517 commit e4a8a96
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ public Pair<Option<String>, JavaRDD<WriteStatus>> syncOnce() throws IOException
|| (newTargetSchema != null && !processedSchema.isSchemaPresent(newTargetSchema))) {
String sourceStr = newSourceSchema == null ? NULL_PLACEHOLDER : newSourceSchema.toString(true);
String targetStr = newTargetSchema == null ? NULL_PLACEHOLDER : newTargetSchema.toString(true);
LOG.info("Seeing new schema. Source: " + sourceStr + ", Target: " + targetStr);
LOG.info("Seeing new schema. Source: {0}, Target: {1}", sourceStr, targetStr);
// We need to recreate write client with new schema and register them.
reInitWriteClient(newSourceSchema, newTargetSchema, recordsFromSource);
if (newSourceSchema != null) {
Expand Down Expand Up @@ -1009,13 +1009,13 @@ public void runMetaSync() {
SyncUtilHelpers.runHoodieMetaSync(impl.trim(), metaProps, conf, fs, cfg.targetBasePath, cfg.baseFileFormat);
success = true;
} catch (HoodieMetaSyncException e) {
LOG.error("SyncTool class " + impl.trim() + " failed with exception", e);
LOG.error("SyncTool class {0} failed with exception {1}", impl.trim(), e);
failedMetaSyncs.put(impl, e);
}
long metaSyncTimeMs = syncContext != null ? syncContext.stop() : 0;
metrics.updateStreamerMetaSyncMetrics(getSyncClassShortName(impl), metaSyncTimeMs);
if (success) {
LOG.info("[MetaSync] SyncTool class " + impl.trim() + " completed successfully and took " + metaSyncTimeMs);
LOG.info("[MetaSync] SyncTool class {0} completed successfully and took {1} ", impl.trim(), metaSyncTimeMs);
}
}
if (!failedMetaSyncs.isEmpty()) {
Expand Down

0 comments on commit e4a8a96

Please sign in to comment.