feat(core): add bulk insert for append-only tables#588
Open
morningstarxcdcode wants to merge 2 commits into
Open
feat(core): add bulk insert for append-only tables#588morningstarxcdcode wants to merge 2 commits into
morningstarxcdcode wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds bulk insert support for unpartitioned, append-only tables in hudi-core by introducing a dedicated writer that writes a Parquet base file and corresponding commit metadata, with tests covering the happy path and partitioned-table rejection.
Changes:
- Introduce
BulkInsertWriter+BulkInsertResultto write Parquet base files and commit metadata for bulk inserts. - Expose
Table::bulk_insert(...)as the public entrypoint delegating to the writer. - Add integration tests validating successful bulk insert and partitioned-table rejection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| crates/core/tests/table_bulk_insert_tests.rs | Adds integration tests for bulk insert success + rejection when table is partitioned. |
| crates/core/src/table/writer.rs | Implements a minimal bulk insert writer: writes Parquet, writes commit metadata (JSON vs Avro for layout v2). |
| crates/core/src/table/mod.rs | Exposes the new writer module and adds Table::bulk_insert. |
Author
|
@xushiyan could you please review it.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds bulk insert support for append-only tables in
hudi-core. so the writer creates a Parquet base file, and writes the matching commit metadata, and rejects partitioned tables for now. The result now exposes the actual commit-relative path, so callers can find the commit file in both timeline layouts .sweetfixes #565.
How are the changes test-covered
Validated with:
cargo test -p hudi-core --test table_bulk_insert_tests -- --nocaptureThe test suite covers the happy path, layout v2 commit placement, and partitioned-table rejection.