Now that ClassicHttpRequests is no longer an enum, we need to way to #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generically build requests from method names. Update all factory classes with matching APIs for Method and String method name inputs.
ok2c
requested changes
Jan 28, 2020
| // TODO Next version of HttpCore: | ||
| // Method.normalizedValueOf(method) | ||
| private static Method normalizedValueOf(final String method) { | ||
| return Method.valueOf(Objects.requireNonNull(method, "method").toUpperCase(Locale.ROOT)); |
There was a problem hiding this comment.
@garydgregory Please use Args.notNull for consistency with the rest of the code base.
ok2c
approved these changes
Jan 28, 2020
|
@garydgregory Looks good to me. Please add the release notes with the same commit if you have to, but please do not do that as a separate commit. |
generically build requests from method names. Update all factory classes with matching APIs for Method and String method name inputs.
garydgregory
added a commit
to garydgregory/httpcomponents-client
that referenced
this pull request
Jan 29, 2020
…pache#205) * Now that ClassicHttpRequests is no longer an enum, we need to way to generically build requests from method names. Update all factory classes with matching APIs for Method and String method name inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generically build requests from method names. Update all factory classes
with matching APIs for Method and String method name inputs.