Bug fix: response Cache-Control attribute does not get updated in the…

… cache execution context in case of a cache miss
apache · Oct 14, 2024 · e7b3a53 · e7b3a53
1 parent aad0e9a
commit e7b3a53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java
@@ -523,7 +523,9 @@ public void cancelled() {
                 return asyncExecCallback.handleResponse(backendResponse, entityDetails);
             }
 
+            final HttpCacheContext context = HttpCacheContext.cast(scope.clientContext);
             final ResponseCacheControl responseCacheControl = CacheControlHeaderParser.INSTANCE.parse(backendResponse);
+            context.setResponseCacheControl(responseCacheControl);
             final boolean cacheable = responseCachingPolicy.isResponseCacheable(responseCacheControl, request, backendResponse);
             if (cacheable) {
                 storeRequestIfModifiedSinceFor304Response(request, backendResponse);

diff --git a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachingExec.java b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachingExec.java
@@ -467,7 +467,9 @@ ClassicHttpResponse handleBackendResponse(
             }
             return backendResponse;
         }
+        final HttpCacheContext context = HttpCacheContext.cast(scope.clientContext);
         final ResponseCacheControl responseCacheControl = CacheControlHeaderParser.INSTANCE.parse(backendResponse);
+        context.setResponseCacheControl(responseCacheControl);
         final boolean cacheable = responseCachingPolicy.isResponseCacheable(responseCacheControl, request, backendResponse);
         if (cacheable) {
             storeRequestIfModifiedSinceFor304Response(request, backendResponse);