Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose s3 object store setting #969

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Jun 5, 2023

Rationale

In order to expose s3 object store

Detailed Changes

Add s3 object store option in setup

Test Plan

Existing tests

@chunshao90 chunshao90 changed the title refactor: expose s3 object store interface feat: expose s3 object store setting Jun 6, 2023
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit eba2293 into apache:main Jun 6, 2023
@baojinri baojinri deleted the feat-support-s3 branch June 19, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants