Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema mismatch during write #966

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Jun 5, 2023

Rationale

Close #308

Detailed Changes

Test Plan

This is a corner case between write and alter schema, the testcase is not easy to construct, so we plan to test this in test env first, then add tests later.

@jiacai2050 jiacai2050 marked this pull request as ready for review June 9, 2023 07:46
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 1a08b2c into apache:main Jun 9, 2023
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Close apache#308 

## Detailed Changes


## Test Plan
This is a corner case between write and alter schema, the testcase is
not easy to construct, so we plan to test this in test env first, then
add tests later.

---------

Co-authored-by: jiacai2050 <dev@liujiacai.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to find memtable to write for schema mismatch
2 participants