Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore row group filter when certain column type #958

Merged
merged 4 commits into from
Jun 2, 2023
Merged

feat: ignore row group filter when certain column type #958

merged 4 commits into from
Jun 2, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jun 1, 2023 •
edited
Loading

Rationale

Part of #955

Detailed Changes

  • Ignore filter for null, double, float, varbinary, boolean
  • Fix parse meta in meta_from_sst

Test Plan

UT and manually

  • Before: max_seq:132734153, size:348.675M, metadata:40.142M, kv:38.175M, filter:28.525M, row_num:7038949
  • After: max_seq:132734153, size:334.045M, metadata:25.512M, kv:23.545M, filter:17.562M, row_num:7038949

@jiacai2050 jiacai2050 requested a review from ShiKaiWi June 1, 2023 06:16
@jiacai2050 jiacai2050 changed the title feat: ignore row group filter when some column feat: ignore row group filter when certain column type Jun 1, 2023
@jiacai2050 jiacai2050 requested a review from ShiKaiWi June 1, 2023 12:04
ShiKaiWi
ShiKaiWi approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit aac76c6 into apache:main Jun 2, 2023
@jiacai2050 jiacai2050 deleted the feat-ignore-filter-builder branch June 2, 2023 02:44
@jiacai2050 jiacai2050 mentioned this pull request Jun 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

@chunshao90 chunshao90 Awaiting requested review from chunshao90

@Rachelint Rachelint Awaiting requested review from Rachelint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ShiKaiWi