Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add rationale part in pr template #957

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

Rationale is important for reviewers

Detailed Changes

  • Add rationale part in PR template

Test Plan

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit ffec264 into apache:main Jun 1, 2023
@jiacai2050 jiacai2050 deleted the chore-template branch June 1, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants