Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade vergen and remove dep libgit2 #951

Merged
merged 2 commits into from
May 31, 2023
Merged

feat: upgrade vergen and remove dep libgit2 #951

merged 2 commits into from
May 31, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented May 31, 2023 •
edited
Loading

Related Issues

Part of #151

Detailed Changes

  • libgit2 used by vergen takes too much time to compile, and we can configure gitcl feature of vergen to remove such dependency.
  • Upgrade vergen to output more information about the compiled binary.

@ShiKaiWi
Copy link
Member Author

ShiKaiWi commented May 31, 2023 •
edited
Loading

The new version output of ceresdb-server:

CeresDB Server 
Version: 1.2.0
Git commit: 778a5b93
Git branch: feat-remove-libgit-dep
Opt level: 3
Rustc version: 1.69.0-nightly
Target: aarch64-apple-darwin
Build date: 2023-05-31T05:05:04.377511000Z

@ShiKaiWi ShiKaiWi requested a review from jiacai2050 May 31, 2023 05:47
chunshao90
chunshao90 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 1872d81 into apache:main May 31, 2023
@ShiKaiWi ShiKaiWi deleted the feat-remove-libgit-dep branch May 31, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

@jiacai2050 jiacai2050 Awaiting requested review from jiacai2050

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiKaiWi @chunshao90