Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the problem of inconsistent error message returned when auto_create_table fails #942

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: the problem of inconsistent error message returned when auto_create_table fails #942

merged 1 commit into from
May 31, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented May 29, 2023 •
edited
Loading

Related Issues

Closes #

Detailed Changes

  • Fix the problem of inconsistent error message returned when auto_create_table fails.
  • Grpc returns more detailed error info.

Test Plan

Manual test and CI.

@chunshao90 chunshao90 force-pushed the fix-auto-create-table-error branch from 732e2bf to b3c5430 Compare May 31, 2023 06:14
@chunshao90 chunshao90 marked this pull request as ready for review May 31, 2023 06:18
jiacai2050
jiacai2050 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 32d3d36 into apache:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunshao90 @jiacai2050