Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: find new columns to improve write performance #918

Merged
merged 3 commits into from
May 24, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented May 23, 2023

Related Issues

Closes #

Detailed Changes

Refactor find new columns to improve write performance.

  • Skip building column schema when columns already exists.

Test Plan

TSBS.

Benchmark

auto_create_table = false auto_create_table = true performance loss
Before 171273.03 rows/s 152436.35 rows/s 11%
After 171699.82 rows/s 164791.73 rows/s 4.1%

@chunshao90 chunshao90 marked this pull request as ready for review May 23, 2023 08:20
proxy/src/write.rs Outdated Show resolved Hide resolved
proxy/src/write.rs Outdated Show resolved Hide resolved
proxy/src/write.rs Outdated Show resolved Hide resolved
@ShiKaiWi
Copy link
Member

@chunshao90 Could you add the unit for the benchmark results (I guess it should be rows/s)?

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit d90a94d into apache:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants