Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove shard from cluster topology after shard closed #908

Merged
merged 6 commits into from
May 23, 2023
Merged

fix: remove shard from cluster topology after shard closed #908

merged 6 commits into from
May 23, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented May 22, 2023 •
edited
Loading

Related Issues

Closes #

Detailed Changes

  • Remove the shard from the cluster topology only after it is closed successfully.
  • Freeze the shard to avoid any updates on it before close the shard, and do shard close with the tables of the frozen shard.
  • Add some logs for open/close shards.

Test Plan

Test with CeresMeta, and trigger closing shard.

Rachelint
Rachelint reviewed May 23, 2023
View reviewed changes
cluster/src/shard_tables_cache.rs Outdated Show resolved Hide resolved
cluster/src/shard_tables_cache.rs Show resolved Hide resolved
cluster/src/shard_tables_cache.rs Outdated Show resolved Hide resolved
ZuLiangWang
ZuLiangWang reviewed May 23, 2023
View reviewed changes
cluster/src/shard_tables_cache.rs Outdated Show resolved Hide resolved
catalog/src/table_operator.rs Outdated Show resolved Hide resolved
server/src/grpc/meta_event_service/mod.rs Show resolved Hide resolved
ZuLiangWang
ZuLiangWang approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit f0216af into apache:main May 23, 2023
@ShiKaiWi ShiKaiWi deleted the fix-close-shard-order branch May 23, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint left review comments

@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShiKaiWi @ZuLiangWang @Rachelint